libwebp: Don't define WEBP_DLL macro when building a static library #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it would define the WEBP_DLL macro unconditionally, which caused it to use the __declspec(dllexport) property when building as a static library on Windows. That caused its symbols to be exported from any target which the static libwebp was linked into (such as an executable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libwebp wrap currently enables the
WEBP_DLLmacro unconditionally, which means on Windows the symbols from a static build of libwebp will be exported, potentially having unintended consequences. To fix that, only define the macro when building shared libraries for libwebp.